AlenkaF commented on PR #41889: URL: https://github.com/apache/arrow/pull/41889#issuecomment-2158301367
Looking at the failing tests in [test-cuda-python](https://github.com/ursacomputing/crossbow/actions/runs/9447414226/job/26019156530): ```python ... > assert cbuf[s].to_pybytes() == arr[s].tobytes() arrow-dev/lib/python3.8/site-packages/pyarrow/tests/test_cuda.py:313: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ pyarrow/io.pxi:1345: in pyarrow.lib.Buffer.__getitem__ ??? _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > ??? E NotImplementedError: Implemented only for data on CPU device pyarrow/io.pxi:1291: NotImplementedError ``` `__getitem__`is expected to work and not error with `NotImplementedError` for `CudaBuffer`. This would then be a breaking change. Should I check if it is an instance of `CudaBuffer` and only if it is not raise an error for non-cpu data? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
