jorisvandenbossche commented on code in PR #41889:
URL: https://github.com/apache/arrow/pull/41889#discussion_r1636340616
##########
python/pyarrow/tests/test_io.py:
##########
@@ -669,6 +669,62 @@ def test_allocate_buffer_resizable():
assert buf.size == 200
+def test_non_cpu_buffer(pickle_module):
+ cuda = pytest.importorskip("pyarrow.cuda")
+ ctx = cuda.Context(0)
+
+ arr = np.array([b'testing'])
+ cuda_buf = ctx.buffer_from_data(arr)
+ arr = pa.FixedSizeBinaryArray.from_buffers(pa.binary(7), 1, [None,
cuda_buf])
+ buf_on_gpu = arr.buffers()[1]
+
+ assert buf_on_gpu.size == cuda_buf.size
+ assert buf_on_gpu.address == cuda_buf.address
+ assert buf_on_gpu.is_cpu == cuda_buf.is_cpu
+ assert buf_on_gpu.is_mutable
+
+ repr1 = "<pyarrow.Buffer address="
+ repr2 = "size=7 is_cpu=False is_mutable=True>"
+ assert repr1 in repr(buf_on_gpu)
+ assert repr2 in repr(buf_on_gpu)
+
+ buf_on_gpu_sliced = buf_on_gpu.slice(2)
+ cuda_sliced = cuda.CudaBuffer.from_buffer(buf_on_gpu_sliced)
+ assert cuda_sliced.to_pybytes() == b'sting'
+
+ buf_on_gpu_sliced = buf_on_gpu[slice(2, 4, 1)]
Review Comment:
```suggestion
buf_on_gpu_sliced = buf_on_gpu[2:4:1]
```
(that's doing exactly the same, but a bit more typical way of spelling it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
