WillAyd commented on code in PR #483:
URL: https://github.com/apache/arrow-nanoarrow/pull/483#discussion_r1635070672


##########
dev/release/rat_exclude_files.txt:
##########
@@ -18,3 +18,4 @@ python/src/nanoarrow/dlpack_abi.h
 subprojects/google-benchmark.wrap
 subprojects/gtest.wrap
 subprojects/nlohmann_json.wrap
+subprojects/zlib.wrap

Review Comment:
   The ones I have excluded were auto generated by `meson wrap install 
<library>` whereas the one that I created from scratch (flatcc.wrap) included 
the Arrow licensing agreement.
   
   Not sure if that distinction matters. Happy to add license agreement to even 
the auto generated ones



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to