WillAyd commented on code in PR #483:
URL: https://github.com/apache/arrow-nanoarrow/pull/483#discussion_r1635323985
##########
src/nanoarrow/meson.build:
##########
@@ -64,6 +64,25 @@ incdir = include_directories('..')
nanoarrow_dep = declare_dependency(include_directories: [curdir, incdir],
link_with: nanoarrow_lib)
+if get_option('ipc')
+ cmake = import('cmake')
+ cmake_opts = cmake.subproject_options()
+ cmake_opts.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': true})
+ flatcc_subproj = cmake.subproject('flatcc', options: cmake_opts)
+ flatcc_dep = flatcc_subproj.dependency('flatccrt')
Review Comment:
I think this is solved in
https://github.com/apache/arrow-nanoarrow/pull/483/files/82a6b48e4218f24b320cfb9e05f972c59d2cdd37..b878e23bb721f07a058e9f63a4db3aa6588f0faa
Basically Meson allows you to provide your own "patch" file for systems that
don't use Meson. The file(s) go in `subprojects/packagefiles/<patch_dir>` and
the wrap system still takes care of fetching / downloading the library for you,
rather than requiring you to vendor into your source tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
