pitrou commented on PR #42067:
URL: https://github.com/apache/arrow/pull/42067#issuecomment-2161027577

   Besides the feature addition, the perf improvement is impressive here:
   ```
   
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   Non-regressions: (47)
   
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                        benchmark           baseline          
contender  change %                                                             
                                                                                
                                                             counters
                       ListSliceInt64List/32768/0   4.550M items/sec  17.254M 
items/sec   279.168                       {'family_index': 0, 
'per_family_instance_index': 5, 'run_name': 'ListSliceInt64List/32768/0', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 96, 
'null_percent': 0.0}
                     ListSliceInt64List/32768/100   4.634M items/sec  17.338M 
items/sec   274.140                     {'family_index': 0, 
'per_family_instance_index': 1, 'run_name': 'ListSliceInt64List/32768/100', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 99, 
'null_percent': 1.0}
                   ListSliceInt64List/32768/10000   4.610M items/sec  17.183M 
items/sec   272.707                  {'family_index': 0, 
'per_family_instance_index': 0, 'run_name': 'ListSliceInt64List/32768/10000', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 97, 
'null_percent': 0.01}
                      ListSliceInt64List/32768/10   5.075M items/sec  18.366M 
items/sec   261.887                    {'family_index': 0, 
'per_family_instance_index': 2, 'run_name': 'ListSliceInt64List/32768/10', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 108, 
'null_percent': 10.0}
               ListSliceInt64ListWithStop/32768/0   6.115M items/sec  21.246M 
items/sec   247.446              {'family_index': 2, 
'per_family_instance_index': 5, 'run_name': 
'ListSliceInt64ListWithStop/32768/0', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 131, 'null_percent': 0.0}
           ListSliceInt64ListWithStop/32768/10000   6.136M items/sec  21.085M 
items/sec   243.606         {'family_index': 2, 'per_family_instance_index': 0, 
'run_name': 'ListSliceInt64ListWithStop/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 132, 'null_percent': 0.01}
             ListSliceInt64ListWithStop/32768/100   6.252M items/sec  21.224M 
items/sec   239.487            {'family_index': 2, 'per_family_instance_index': 
1, 'run_name': 'ListSliceInt64ListWithStop/32768/100', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 133, 'null_percent': 1.0}
              ListSliceInt64ListWithStop/32768/10   6.777M items/sec  22.361M 
items/sec   229.957            {'family_index': 2, 'per_family_instance_index': 
2, 'run_name': 'ListSliceInt64ListWithStop/32768/10', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 144, 'null_percent': 10.0}
                       ListSliceInt64List/32768/2   8.474M items/sec  25.678M 
items/sec   203.033                     {'family_index': 0, 
'per_family_instance_index': 3, 'run_name': 'ListSliceInt64List/32768/2', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 182, 
'null_percent': 50.0}
               ListSliceInt64ListWithStop/32768/2  11.064M items/sec  29.813M 
items/sec   169.468             {'family_index': 2, 
'per_family_instance_index': 3, 'run_name': 
'ListSliceInt64ListWithStop/32768/2', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 236, 'null_percent': 50.0}
                  ListSliceInt64ListToFSL/32768/0   6.432M items/sec  16.445M 
items/sec   155.684                 {'family_index': 6, 
'per_family_instance_index': 5, 'run_name': 'ListSliceInt64ListToFSL/32768/0', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 138, 
'null_percent': 0.0}
                ListSliceInt64ListToFSL/32768/100   6.484M items/sec  16.443M 
items/sec   153.611               {'family_index': 6, 
'per_family_instance_index': 1, 'run_name': 
'ListSliceInt64ListToFSL/32768/100', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 138, 'null_percent': 1.0}
              ListSliceInt64ListToFSL/32768/10000   6.405M items/sec  16.019M 
items/sec   150.102            {'family_index': 6, 'per_family_instance_index': 
0, 'run_name': 'ListSliceInt64ListToFSL/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 135, 'null_percent': 0.01}
                 ListSliceInt64ListToFSL/32768/10   6.938M items/sec  17.026M 
items/sec   145.387               {'family_index': 6, 
'per_family_instance_index': 2, 'run_name': 'ListSliceInt64ListToFSL/32768/10', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 148, 
'null_percent': 10.0}
                  ListSliceInt64ListToFSL/32768/2  10.459M items/sec  21.278M 
items/sec   103.445                {'family_index': 6, 
'per_family_instance_index': 3, 'run_name': 'ListSliceInt64ListToFSL/32768/2', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 222, 
'null_percent': 50.0}
                      ListSliceStringList/32768/0   6.559M items/sec  10.085M 
items/sec    53.743                     {'family_index': 1, 
'per_family_instance_index': 5, 'run_name': 'ListSliceStringList/32768/0', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 140, 
'null_percent': 0.0}
                     ListSliceStringList/32768/10   7.210M items/sec  10.935M 
items/sec    51.671                   {'family_index': 1, 
'per_family_instance_index': 2, 'run_name': 'ListSliceStringList/32768/10', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 155, 
'null_percent': 10.0}
                    ListSliceStringList/32768/100   6.916M items/sec  10.134M 
items/sec    46.528                   {'family_index': 1, 
'per_family_instance_index': 1, 'run_name': 'ListSliceStringList/32768/100', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 148, 
'null_percent': 1.0}
                  ListSliceStringList/32768/10000   6.873M items/sec   9.960M 
items/sec    44.907                {'family_index': 1, 
'per_family_instance_index': 0, 'run_name': 'ListSliceStringList/32768/10000', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 147, 
'null_percent': 0.01}
                      ListSliceStringList/32768/2  11.798M items/sec  16.995M 
items/sec    44.048                    {'family_index': 1, 
'per_family_instance_index': 3, 'run_name': 'ListSliceStringList/32768/2', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 251, 
'null_percent': 50.0}
            ListSliceStringListWithStop/32768/100   9.359M items/sec  13.474M 
items/sec    43.970           {'family_index': 3, 'per_family_instance_index': 
1, 'run_name': 'ListSliceStringListWithStop/32768/100', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 199, 'null_percent': 1.0}
          ListSliceStringListWithStop/32768/10000   9.251M items/sec  13.209M 
items/sec    42.789        {'family_index': 3, 'per_family_instance_index': 0, 
'run_name': 'ListSliceStringListWithStop/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 198, 'null_percent': 0.01}
              ListSliceStringListWithStop/32768/0   9.247M items/sec  13.194M 
items/sec    42.689             {'family_index': 3, 
'per_family_instance_index': 5, 'run_name': 
'ListSliceStringListWithStop/32768/0', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 197, 'null_percent': 0.0}
             ListSliceStringListWithStop/32768/10  10.078M items/sec  14.259M 
items/sec    41.495           {'family_index': 3, 'per_family_instance_index': 
2, 'run_name': 'ListSliceStringListWithStop/32768/10', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 215, 'null_percent': 10.0}
              ListSliceStringListWithStop/32768/2  15.709M items/sec  21.183M 
items/sec    34.850            {'family_index': 3, 'per_family_instance_index': 
3, 'run_name': 'ListSliceStringListWithStop/32768/2', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 338, 'null_percent': 50.0}
               ListSliceStringListToFSL/32768/100   8.740M items/sec  11.488M 
items/sec    31.437              {'family_index': 7, 
'per_family_instance_index': 1, 'run_name': 
'ListSliceStringListToFSL/32768/100', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 187, 'null_percent': 1.0}
             ListSliceStringListToFSL/32768/10000   8.738M items/sec  11.392M 
items/sec    30.371           {'family_index': 7, 'per_family_instance_index': 
0, 'run_name': 'ListSliceStringListToFSL/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 186, 'null_percent': 0.01}
                 ListSliceStringListToFSL/32768/0   8.669M items/sec  11.284M 
items/sec    30.162                {'family_index': 7, 
'per_family_instance_index': 5, 'run_name': 'ListSliceStringListToFSL/32768/0', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 184, 
'null_percent': 0.0}
                ListSliceStringListToFSL/32768/10   9.309M items/sec  12.093M 
items/sec    29.903              {'family_index': 7, 
'per_family_instance_index': 2, 'run_name': 
'ListSliceStringListToFSL/32768/10', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 200, 'null_percent': 10.0}
                 ListSliceStringListToFSL/32768/2  13.531M items/sec  16.373M 
items/sec    21.005               {'family_index': 7, 
'per_family_instance_index': 3, 'run_name': 'ListSliceStringListToFSL/32768/2', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 290, 
'null_percent': 50.0}
        ListSliceInt64ListWithStepAndStop/32768/0  10.456M items/sec  11.469M 
items/sec     9.684       {'family_index': 4, 'per_family_instance_index': 5, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/0', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 224, 'null_percent': 0.0}
        ListSliceInt64ListWithStepAndStop/32768/2  17.368M items/sec  18.678M 
items/sec     7.543      {'family_index': 4, 'per_family_instance_index': 3, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/2', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 371, 'null_percent': 50.0}
    ListSliceInt64ListWithStepAndStop/32768/10000  10.541M items/sec  11.299M 
items/sec     7.194  {'family_index': 4, 'per_family_instance_index': 0, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 226, 'null_percent': 0.01}
       ListSliceInt64ListWithStepAndStop/32768/10  11.407M items/sec  12.222M 
items/sec     7.142     {'family_index': 4, 'per_family_instance_index': 2, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/10', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 244, 'null_percent': 10.0}
      ListSliceInt64ListWithStepAndStop/32768/100  10.653M items/sec  11.372M 
items/sec     6.747     {'family_index': 4, 'per_family_instance_index': 1, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/100', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 227, 'null_percent': 1.0}
       ListSliceStringListWithStepAndStop/32768/0  15.761M items/sec  16.382M 
items/sec     3.943      {'family_index': 5, 'per_family_instance_index': 5, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/0', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 337, 'null_percent': 0.0}
     ListSliceStringListWithStepAndStop/32768/100  15.973M items/sec  16.338M 
items/sec     2.286    {'family_index': 5, 'per_family_instance_index': 1, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/100', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 342, 'null_percent': 1.0}
   ListSliceStringListWithStepAndStop/32768/10000  15.892M items/sec  16.126M 
items/sec     1.476 {'family_index': 5, 'per_family_instance_index': 0, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/10000', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 338, 'null_percent': 0.01}
      ListSliceStringListWithStepAndStop/32768/10  17.057M items/sec  17.257M 
items/sec     1.173    {'family_index': 5, 'per_family_instance_index': 2, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/10', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 364, 'null_percent': 10.0}
                  ListSliceInt64ListToFSL/32768/1  51.086M items/sec  51.610M 
items/sec     1.025              {'family_index': 6, 
'per_family_instance_index': 4, 'run_name': 'ListSliceInt64ListToFSL/32768/1', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 1075, 
'null_percent': 100.0}
       ListSliceStringListWithStepAndStop/32768/2  24.469M items/sec  24.713M 
items/sec     0.996     {'family_index': 5, 'per_family_instance_index': 3, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/2', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 520, 'null_percent': 50.0}
              ListSliceStringListWithStop/32768/1 107.170M items/sec 105.429M 
items/sec    -1.625          {'family_index': 3, 'per_family_instance_index': 
4, 'run_name': 'ListSliceStringListWithStop/32768/1', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 2284, 'null_percent': 100.0}
                 ListSliceStringListToFSL/32768/1  46.991M items/sec  46.204M 
items/sec    -1.675              {'family_index': 7, 
'per_family_instance_index': 4, 'run_name': 'ListSliceStringListToFSL/32768/1', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 999, 
'null_percent': 100.0}
               ListSliceInt64ListWithStop/32768/1 111.994M items/sec 109.251M 
items/sec    -2.449           {'family_index': 2, 'per_family_instance_index': 
4, 'run_name': 'ListSliceInt64ListWithStop/32768/1', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 2395, 'null_percent': 100.0}
                      ListSliceStringList/32768/1 108.063M items/sec 105.083M 
items/sec    -2.758                  {'family_index': 1, 
'per_family_instance_index': 4, 'run_name': 'ListSliceStringList/32768/1', 
'repetitions': 1, 'repetition_index': 0, 'threads': 1, 'iterations': 2310, 
'null_percent': 100.0}
       ListSliceStringListWithStepAndStop/32768/1 108.135M items/sec 105.112M 
items/sec    -2.796   {'family_index': 5, 'per_family_instance_index': 4, 
'run_name': 'ListSliceStringListWithStepAndStop/32768/1', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 2318, 'null_percent': 100.0}
        ListSliceInt64ListWithStepAndStop/32768/1 111.933M items/sec 108.597M 
items/sec    -2.980    {'family_index': 4, 'per_family_instance_index': 4, 
'run_name': 'ListSliceInt64ListWithStepAndStop/32768/1', 'repetitions': 1, 
'repetition_index': 0, 'threads': 1, 'iterations': 2390, 'null_percent': 100.0}
   
   
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   Regressions: (1)
   
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                    benchmark           baseline          contender  change %   
                                                                                
                                                                                
                     counters
   ListSliceInt64List/32768/1 116.649M items/sec 108.497M items/sec    -6.989 
{'family_index': 0, 'per_family_instance_index': 4, 'run_name': 
'ListSliceInt64List/32768/1', 'repetitions': 1, 'repetition_index': 0, 
'threads': 1, 'iterations': 2477, 'null_percent': 100.0}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to