felipecrv commented on code in PR #42067: URL: https://github.com/apache/arrow/pull/42067#discussion_r1635210130
########## cpp/src/arrow/compute/kernels/scalar_nested.cc: ########## @@ -28,6 +28,7 @@ #include "arrow/util/bit_util.h" #include "arrow/util/bitmap_generate.h" #include "arrow/util/string.h" +#include "arrow/util/unreachable.h" Review Comment: In this specific case, I wouldn't like UB when `Unreachable()` is reached because the logic in the switch is non-trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
