wjones127 commented on code in PR #5862:
URL: https://github.com/apache/arrow-rs/pull/5862#discussion_r1635324313
##########
arrow-select/src/concat.rs:
##########
@@ -54,6 +54,22 @@ fn binary_capacity<T: ByteArrayType>(arrays: &[&dyn Array])
-> Capacities {
Capacities::Binary(item_capacity, Some(bytes_capacity))
}
+fn fixed_size_list_capacity(arrays: &[&dyn Array], data_type: &DataType) ->
Capacities {
+ if let DataType::FixedSizeList(f, _) = data_type {
Review Comment:
Should this be returning `Capacities::Array()` if the children are primitive
/ fixed size? I ask because I see it handled above and it seems like it would
avoid some allocations and iteration over children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
