judahrand commented on code in PR #5862:
URL: https://github.com/apache/arrow-rs/pull/5862#discussion_r1636090875
##########
arrow-select/src/concat.rs:
##########
@@ -54,6 +54,22 @@ fn binary_capacity<T: ByteArrayType>(arrays: &[&dyn Array])
-> Capacities {
Capacities::Binary(item_capacity, Some(bytes_capacity))
}
+fn fixed_size_list_capacity(arrays: &[&dyn Array], data_type: &DataType) ->
Capacities {
+ if let DataType::FixedSizeList(f, _) = data_type {
Review Comment:
Yup, that's fair we can avoid at least one iteration and a `Box::new()` if
only recursively call `get_capacity()` when we know that it will have some
special handling other than `Capacities::Array(arrays.iter().map(|a|
a.len()).sum())`.
https://github.com/apache/arrow-rs/pull/5862/commits/b30566ab3ddcd3def86e889c0be9617cdf90dab5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
