stevelorddremio commented on code in PR #42035:
URL: https://github.com/apache/arrow/pull/42035#discussion_r1635509607
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/client/ArrowFlightSqlClientHandler.java:
##########
@@ -761,6 +812,16 @@ public Builder withCallOptions(final
Collection<CallOption> options) {
return this;
}
+ /**
+ * Sets the catalog for this handler.
+ * @param catalog the catalog
+ * @return this instance.
+ */
+ public Builder withCatalog(final String catalog) {
+ this.catalog = catalog;
Review Comment:
Hmm, I made Optional now, which means I pass Optional as a parameter into
the constructor. Not feeling that is the best practice, but have restricted
the scope of createNewHandler() to package. Added extra unit tests to safe
guard against possible NPE later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
