lidavidm commented on code in PR #42035:
URL: https://github.com/apache/arrow/pull/42035#discussion_r1635804618
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/client/ArrowFlightSqlClientHandler.java:
##########
@@ -761,6 +812,16 @@ public Builder withCallOptions(final
Collection<CallOption> options) {
return this;
}
+ /**
+ * Sets the catalog for this handler.
+ * @param catalog the catalog
+ * @return this instance.
+ */
+ public Builder withCatalog(final String catalog) {
+ this.catalog = catalog;
Review Comment:
Ah...what you had originally was fine then, but I was more questioning if
empty string for catalog is valid (can't a system have an unnamed default
catalog?) in which case it would be better to only differentiate between
null/not-null. I proposed Optional to be explicit about the semantics but
certainly `@Nullable String` is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
