paleolimbot commented on PR #520: URL: https://github.com/apache/arrow-nanoarrow/pull/520#issuecomment-2161671910
I think that the issue was that the mingw inttypes.h header ( https://github.com/msys2-contrib/mingw-w64/blob/master/mingw-w64-headers/crt/inttypes.h ) had some interactions with the format check attribute and `__USE_MINGW_ANSI_STDIO`: https://github.com/apache/arrow-adbc/blob/acef3c826599c5d4c18849bfe2164d8d0ce53fbc/c/driver/common/utils.h#L34-L41 I don't think that the format check attribute is particularly important (it is opt-in via the `NANOARROW_DEBUG` define), so I think `PRId64` is safe 🙂 . The old version of mingw that was causing problems was the basis for the R package build toolchain for R <= 3.6, but that version just went out of the tidyverse support matrix. I was had been thinking something like `#define NANOARROW_PR64(EXPR) ((int64_t)value)` + `ArrowErrorSet("Some big value is %" NANOARROW_PRID64, NANOARROW_PR64(some_value))`, but since the issue was actually just the format check attribute and not the format itself, I don't think it's needed 🙂 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
