paleolimbot commented on code in PR #520:
URL: https://github.com/apache/arrow-nanoarrow/pull/520#discussion_r1636495893
##########
src/nanoarrow/nanoarrow_device.c:
##########
@@ -365,8 +366,9 @@ ArrowErrorCode ArrowDeviceArrayViewSetArrayMinimal(
struct ArrowDevice* device =
ArrowDeviceResolve(device_array->device_type, device_array->device_id);
if (device == NULL) {
- ArrowErrorSet(error, "Can't resolve device with type %d and identifier
%ld",
- (int)device_array->device_type,
(long)device_array->device_id);
+ ArrowErrorSet(error,
+ "Can't resolve device with type %" PRId32 " and identifier
%l" PRId64,
Review Comment:
```suggestion
"Can't resolve device with type %" PRId32 " and identifier
%" PRId64,
```
##########
src/nanoarrow/array.c:
##########
@@ -1145,7 +1152,7 @@ static int ArrowAssertIncreasingInt64(struct
ArrowBufferView view,
for (int64_t i = 1; i < view.size_bytes / (int64_t)sizeof(int64_t); i++) {
if (view.data.as_int64[i] < view.data.as_int64[i - 1]) {
- ArrowErrorSet(error, "[%ld] Expected element size >= 0", (long)i);
+ ArrowErrorSet(error, "[%" PRId64 "] Expected element size >= 0",
(long)i);
Review Comment:
```suggestion
ArrowErrorSet(error, "[%" PRId64 "] Expected element size >= 0", i);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
