vibhatha commented on code in PR #42038:
URL: https://github.com/apache/arrow/pull/42038#discussion_r1636658726
##########
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java:
##########
@@ -129,6 +121,25 @@ public void testJdbcToArrowValues() throws SQLException,
IOException {
Calendar.getInstance(TimeZone.getTimeZone(table.getTimezone())))
.build()),
false);
+ testDataSets(
+ sqlToArrow(
+ conn.createStatement().executeQuery(table.getQuery()),
+ new RootAllocator(Integer.MAX_VALUE),
+ Calendar.getInstance(TimeZone.getTimeZone(table.getTimezone()))),
+ false);
+ testDataSets(
+ sqlToArrow(
+ conn.createStatement().executeQuery(table.getQuery()),
+ Calendar.getInstance(TimeZone.getTimeZone(table.getTimezone()))),
+ false);
+ testDataSets(
+ sqlToArrow(
+ conn.createStatement().executeQuery(table.getQuery()),
+ new JdbcToArrowConfigBuilder(
+ new RootAllocator(Integer.MAX_VALUE),
+
Calendar.getInstance(TimeZone.getTimeZone(table.getTimezone())))
+ .build()),
+ false);
Review Comment:
could I get bit of an explanation about this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
