WillAyd commented on code in PR #523:
URL: https://github.com/apache/arrow-nanoarrow/pull/523#discussion_r1636970130
##########
src/nanoarrow/array_test.cc:
##########
@@ -87,12 +87,6 @@ TEST(ArrayTest, ArrayTestAllocateChildren) {
EXPECT_EQ(array.n_children, 0);
ArrowArrayRelease(&array);
- ASSERT_EQ(ArrowArrayInitFromType(&array, NANOARROW_TYPE_STRUCT),
NANOARROW_OK);
Review Comment:
Unfortunately ASAN does not like this code block:
```
==897112==ERROR: AddressSanitizer: requested allocation size
0x7ffffffffffffff8 (0x8000000000000ff8 after adjustments for alignment, red
zones etc.) exceeds maximum supported size of 0x10000000000 (thread T0)
```
It might be possible to add a function attribute to disable instrumentation:
https://github.com/google/sanitizers/wiki/AddressSanitizer#turning-off-instrumentation
But couldn't find a reasonable way to make that work with gtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
