paleolimbot commented on code in PR #523:
URL: https://github.com/apache/arrow-nanoarrow/pull/523#discussion_r1638719532
##########
ci/scripts/build-with-meson.sh:
##########
@@ -65,16 +65,52 @@ function main() {
pushd "${SANDBOX_DIR}"
- show_header "Run test suite"
- meson configure -Dtests=true -Db_coverage=true -Dipc=true
+ show_header "Run ASAN/UBSAN test suite"
Review Comment:
> I do think it would be nice to make the Meson job run as part of regular
CI in a follow up if that's something you are open to.
Definitely! Off the top of my head it would be nice to at least make sure
the build works, and perhaps anything else that doesn't extend the iteration
time of a normal CI run (the longest running job is I think the IPC valgrind
job).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
