ZhangHuiGui commented on code in PR #41975:
URL: https://github.com/apache/arrow/pull/41975#discussion_r1638413106
##########
cpp/src/arrow/compute/exec.cc:
##########
@@ -738,12 +772,10 @@ class KernelExecutorImpl : public KernelExecutor {
}
for (size_t i = 0; i < data_preallocated_.size(); ++i) {
const auto& prealloc = data_preallocated_[i];
- if (prealloc.bit_width >= 0) {
Review Comment:
> `fixed_size_binary<0>` can have `bit_width == 0`
Yes, `fixed_size_binary<0>` can be added into `data_preallocated_` normally
in `ComputeDataPreallocate`, and the function call make sure all of element in
`data_preallocated_` should satisfy `>=0`. So we just add a DCHECK here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
