ZhangHuiGui commented on code in PR #41975:
URL: https://github.com/apache/arrow/pull/41975#discussion_r1639161144
##########
cpp/src/arrow/compute/exec.cc:
##########
@@ -1123,6 +1142,34 @@ class VectorExecutor : public
KernelExecutorImpl<VectorKernel> {
}
}
+ Status SetupPreallocation(const std::vector<Datum>& args) {
Review Comment:
> And what if `kernel_->null_handling == NullHandling::OUTPUT_NOT_NULL`?
`Kernel output is never null and a validity bitmap does not need to be
allocated`.
validity_preallocated_ just preallocate the validity bitmap-buffer which
unnecessary for `OUTPUT_NOT_NULL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
