llama90 commented on code in PR #42158: URL: https://github.com/apache/arrow/pull/42158#discussion_r1641834180
########## java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/calendar/ArrowFlightJdbcIntervalVectorAccessorTest.java: ########## Review Comment: Point 2. `ParameterizedTest` Some methods do not need the `@ParameterizedTest` annotation, so these methods are executed with the `@Test` annotation. However, this causes a discrepancy in the number of tests between the main branch (1036) and the current branch (1030). - `testShouldGetIntervalYear` - `testShouldGetIntervalDay` - `testIntervalDayWithJodaPeriodObject` ```bash --- main branch [WARNING] Tests run: 1036, Failures: 0, Errors: 0, Skipped: 30 --- ARROW-42045 branch [WARNING] Tests run: 1030, Failures: 0, Errors: 0, Skipped: 30 ``` I have also verified that the methods have been updated to use the `@ParameterizedTest` annotation where necessary. Is it okay to keep it as it is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
