llama90 commented on code in PR #42158: URL: https://github.com/apache/arrow/pull/42158#discussion_r1644223342
##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java:
##########
@@ -193,9 +189,14 @@ public void
testShouldGetBigDecimalMethodFromFloat4Vector() throws Exception {
(accessor, currentRow) -> {
float value = accessor.getFloat();
if (Float.isInfinite(value) || Float.isNaN(value)) {
- exceptionCollector.expect(SQLException.class);
+ assertThrows(
+ SQLException.class,
+ () -> {
+ throw new SQLException();
+ });
+ } else {
+ assertThat(accessor.getBigDecimal(),
is(BigDecimal.valueOf(value)));
Review Comment:
Fixed it.
https://github.com/apache/arrow/blob/323c70905aee03055d252924e8ab0a7b997d4f10/java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java#L191-L195
https://github.com/apache/arrow/blob/323c70905aee03055d252924e8ab0a7b997d4f10/java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java#L205-L211
https://github.com/apache/arrow/blob/323c70905aee03055d252924e8ab0a7b997d4f10/java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat8VectorAccessorTest.java#L144-L148
https://github.com/apache/arrow/blob/323c70905aee03055d252924e8ab0a7b997d4f10/java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat8VectorAccessorTest.java#L184-L190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
