lidavidm commented on code in PR #41646:
URL: https://github.com/apache/arrow/pull/41646#discussion_r1643608747
##########
cpp/src/arrow/engine/substrait/serde.h:
##########
@@ -183,6 +184,13 @@ ARROW_ENGINE_EXPORT Result<BoundExpressions>
DeserializeExpressions(
const ConversionOptions& conversion_options = {},
ExtensionSet* ext_set_out = NULLPTR);
+/// \brief Deserialize a Substrait Literal message to the map
+///
+/// \param[in] buf a buffer containing the protobuf serialization of a
Substrait Literal
+/// \param[out] out deserialize to this map.
+ARROW_ENGINE_EXPORT Status
+DeserializeMap(const Buffer& buf, std::unordered_map<std::string,
std::string>& out);
Review Comment:
Standard Protobuf dependency + Protobuf well-known-type, or don't use
Protobuf at all and find some other serialization method that doesn't carry
this heavy of a dependency. (Some parts of the JNI code just directly pass a
Java Map reference and use JNI to extract the key/value pairs on the C++ side,
for instance.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
