vibhatha commented on code in PR #41646:
URL: https://github.com/apache/arrow/pull/41646#discussion_r1645275950
##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -363,6 +364,64 @@ std::shared_ptr<arrow::Buffer>
LoadArrowBufferFromByteBuffer(JNIEnv* env, jobjec
return buffer;
}
+inline bool ParseBool(const std::string& value) { return value == "true" ?
true : false; }
+
+/// \brief Construct FragmentScanOptions from config map
+#ifdef ARROW_CSV
+arrow::Result<std::shared_ptr<arrow::dataset::FragmentScanOptions>>
+ToCsvFragmentScanOptions(const std::unordered_map<std::string, std::string>&
configs) {
+ std::shared_ptr<arrow::dataset::CsvFragmentScanOptions> options =
+ std::make_shared<arrow::dataset::CsvFragmentScanOptions>();
+ for (auto const& it : configs) {
+ auto& key = it.first;
+ auto& value = it.second;
+ if (key == "delimiter") {
+ options->parse_options.delimiter = value.data()[0];
+ } else if (key == "quoting") {
+ options->parse_options.quoting = ParseBool(value);
+ } else if (key == "column_types") {
+ int64_t schema_address = std::stol(value);
+ ArrowSchema* cSchema = reinterpret_cast<ArrowSchema*>(schema_address);
+ ARROW_ASSIGN_OR_RAISE(auto schema, arrow::ImportSchema(cSchema));
+ auto& column_types = options->convert_options.column_types;
+ for (auto field : schema->fields()) {
+ column_types[field->name()] = field->type();
+ }
+ } else if (key == "strings_can_be_null") {
+ options->convert_options.strings_can_be_null = ParseBool(value);
+ } else {
+ return arrow::Status::Invalid("Config " + it.first + " is not
supported.");
+ }
+ }
+ return options;
+}
+#endif
+
+arrow::Result<std::shared_ptr<arrow::dataset::FragmentScanOptions>>
+GetFragmentScanOptions(jint file_format_id,
+ const std::unordered_map<std::string, std::string>&
configs) {
+ switch (file_format_id) {
+#ifdef ARROW_CSV
+ case 3:
+ return ToCsvFragmentScanOptions(configs);
+#endif
+ default:
+ return arrow::Status::Invalid("Illegal file format id: ",
file_format_id);
+ }
+}
+
+std::unordered_map<std::string, std::string> ToStringMap(JNIEnv* env,
+ jobjectArray&
str_array) {
+ int length = env->GetArrayLength(str_array);
+ std::unordered_map<std::string, std::string> map;
+ for (int i = 0; i < length; i += 2) {
Review Comment:
Since we do `i =+2`, should we ensure the length is even? And maybe reserve
the map since we know the length?
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/FragmentScanOptions.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.arrow.dataset.scanner;
+
+import java.util.Map;
+
+public interface FragmentScanOptions {
+ String typeName();
+
+ int fileFormatId();
+
+ String[] serialize();
+
+ /**
+ * Serialize the map to string array.
+ *
+ * @param config config map
+ * @return string array for serialization
+ */
+ default String[] serializeMap(Map<String, String> config) {
Review Comment:
Are we actually doing any serialization here or just converting a map to a
String[] such that even indexes are keys and odd indexes are values? Maybe a
different name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
