llama90 commented on code in PR #42158:
URL: https://github.com/apache/arrow/pull/42158#discussion_r1644690673
##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/utils/CoreMockedSqlProducers.java:
##########
@@ -324,12 +324,16 @@ public static void assertLegacyRegularSqlResultSet(
actualHireDates.add((Date) resultSet.getObject(5));
actualLastSales.add((Timestamp) resultSet.getObject(6));
}
- collector.checkThat(actualRowCount, is(equalTo(expectedRowCount)));
- collector.checkThat(actualIds, is(expectedIds));
- collector.checkThat(actualNames, is(expectedNames));
- collector.checkThat(actualAges, is(expectedAges));
- collector.checkThat(actualSalaries, is(expectedSalaries));
- collector.checkThat(actualHireDates, is(expectedHireDates));
- collector.checkThat(actualLastSales, is(expectedLastSales));
+
+ final int finalActualRowCount = actualRowCount;
Review Comment:
If we don't use `final`, we'll see the error: "Variable used in lambda
expression should be final or effectively final."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
