asfimport commented on issue #42263: URL: https://github.com/apache/arrow/issues/42263#issuecomment-2184204379
[Kalon Mills](https://issues.apache.org/jira/browse/PARQUET-267?#comment-15088856) / @kalaxy: I have a new [branch](https://github.com/kalaxy/parquet-cpp/tree/libparquet-library-update-build) where I rebased my cmake changes from the original pull request off of Wes' changes. I also removed the thirdparty lz4 code and added support for downloading it in the download_thirdparty.sh script. This basically keeps the original sandbox in place while removing and specifics for it from the build system. For the final commit, I also pulled thrift into the thirdparty setup scripts. But I got to wondering, do you think thrift should be provided by the sandbox scripts? Thrift is pretty finicky to build. So it may to a constant thorn to try and maintain a script that can build and install it on multiple platforms. Thrift also has a fair number of dependencies so it complicates describing how to get a dependencies in order. I wonder what your thoughts are. At a minimum, I can pull the last commit off and we'd be back to the same sandbox capabilities as before but with a cleaner build config. A couple of other things: - I cleaned up the .travisci a bit because things like g++4.9 weren't actually getting used. (I tried to get the 4.9 build working for several hours but had no luck. Maybe another day.) - In pulling the lz4 directly from github, the api used had to be updated. Apparently the version used in the committed code was very old. - Currently the thirdparty scripts still have to use the repo's thirdparty/ directory. I think it would be nicer in the future to move thirdparty libraries to the actual build directory. Anyway let me know what you think and if you think this is going in a good direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
