asfimport commented on issue #42263:
URL: https://github.com/apache/arrow/issues/42263#issuecomment-2184204366

   [Kalon 
Mills](https://issues.apache.org/jira/browse/PARQUET-267?#comment-15086575) / 
@kalaxy:
   @nongli, I agree that a sandboxed env would be very useful for quickstart 
development.  I think, however, that it should be a script which initializes 
the environment for use, rather than part of the build configuration.  Right 
now, apache/parquet-cpp:master requires download_thirdparty.sh and 
build_thirdparty.sh to be run as prerequisites to running cmake because cmake 
relies on specifics.
   
   I'd rather see a cmake configuration that is customizable for determining 
library locations and then an `./initialize_sandbox.sh <path_to_build_dir>` 
which can download and install everything required by the sandbox as well as 
configure cmake in that directory with the sandbox libraries.  (In fact this 
would make the travisci build configuration simpler too because travisci could 
leverage the sandbox env.)
   
   I think this is what @wesm is getting at with his comment above.  My pull 
request here does three, I think important, things.  
   1. It removes third party code from the repo.  
   1. It makes library discovery more generic.  
   1. It decouples the build configuration from the build environment.  
   
   With this as a foundation, I think that one can script sandbox creation in a 
straightforward and decoupled manner.  
   
   I guess your point is that with this pull request I'm removing an existing 
sandbox solution, but I'm hoping that this would be a good stepping stone for a 
better solution.  I don't want to duplicate work that Wes is doing, but if 
you'd like I can implement a version of initialize_sandbox.sh so that the 
sandbox feature still exists.  @wesm is that sort of the direction you were 
already headed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to