mapleFU commented on code in PR #43066: URL: https://github.com/apache/arrow/pull/43066#discussion_r1659514750
########## go/parquet/internal/encoding/byte_stream_split.go: ########## @@ -0,0 +1,297 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package encoding + +import ( + "math" + + "github.com/apache/arrow/go/v17/arrow" + "github.com/apache/arrow/go/v17/internal/bitutils" + "github.com/apache/arrow/go/v17/internal/utils" + "github.com/apache/arrow/go/v17/parquet" + "golang.org/x/xerrors" +) + +type NumericByteStreamSplitType interface { + float32 | float64 | int32 | int64 +} + +type ByteStreamSplitType interface { + NumericByteStreamSplitType | parquet.FixedLenByteArray +} + +// putByteStreamSplitNumeric is a generic implementation of the BYTE_STREAM_SPLIT encoding for fixed-width numeric types. +func putByteStreamSplitNumeric[T NumericByteStreamSplitType](in []T, enc TypedEncoder, sink *PooledBufferWriter) { + numElements := len(in) + typeLen := enc.Type().ByteSize() + bytesNeeded := numElements * typeLen + sink.Reserve(bytesNeeded) + + // Make sure len = cap so we can index into any loc rather than append Review Comment: should we make some assertion here? ########## go/parquet/internal/encoding/byte_stream_split.go: ########## @@ -0,0 +1,297 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package encoding + +import ( + "math" + + "github.com/apache/arrow/go/v17/arrow" + "github.com/apache/arrow/go/v17/internal/bitutils" + "github.com/apache/arrow/go/v17/internal/utils" + "github.com/apache/arrow/go/v17/parquet" + "golang.org/x/xerrors" +) + +type NumericByteStreamSplitType interface { + float32 | float64 | int32 | int64 +} + +type ByteStreamSplitType interface { + NumericByteStreamSplitType | parquet.FixedLenByteArray +} + +// putByteStreamSplitNumeric is a generic implementation of the BYTE_STREAM_SPLIT encoding for fixed-width numeric types. +func putByteStreamSplitNumeric[T NumericByteStreamSplitType](in []T, enc TypedEncoder, sink *PooledBufferWriter) { + numElements := len(in) + typeLen := enc.Type().ByteSize() + bytesNeeded := numElements * typeLen + sink.Reserve(bytesNeeded) + + // Make sure len = cap so we can index into any loc rather than append + data := sink.buf.Bytes() + data = data[:cap(data)] + + inBytes := arrow.GetBytes(in) + for offset := 0; offset < typeLen; offset++ { + for element := range in { + encLoc := numElements*offset + element + decLoc := typeLen*element + offset + data[encLoc] = inBytes[decLoc] + } + } + + sink.pos += bytesNeeded +} + +// putByteStreamSplitSpaced encodes data that has space for nulls using the BYTE_STREAM_SPLIT encoding, calling to the provided putFn to encode runs of non-null values. +func putByteStreamSplitSpaced[T ByteStreamSplitType](in []T, validBits []byte, validBitsOffset int64, bitSetReader bitutils.SetBitRunReader, putFn func([]T)) { + if validBits == nil { + putFn(in) + return + } + + if bitSetReader == nil { + bitSetReader = bitutils.NewSetBitRunReader(validBits, validBitsOffset, int64(len(in))) + } else { + bitSetReader.Reset(validBits, validBitsOffset, int64(len(in))) + } + + for { + run := bitSetReader.NextRun() + if run.Length == 0 { + break + } + putFn(in[int(run.Pos):int(run.Pos+run.Length)]) + } +} + +// decodeByteStreamSplit is a generic implementation of the BYTE_STREAM_SPLIT decoder for fixed-width numeric types. +func decodeByteStreamSplitNumeric[T NumericByteStreamSplitType](out []T, dec TypedDecoder, data []byte) (int, error) { + max := utils.Min(len(out), dec.ValuesLeft()) + typeLen := dec.Type().ByteSize() + numBytesNeeded := max * typeLen + if numBytesNeeded > len(data) || numBytesNeeded > math.MaxInt32 { + return 0, xerrors.New("parquet: eof exception") + } + + outBytes := arrow.GetBytes(out) + for offset := 0; offset < typeLen; offset++ { Review Comment: offset -> stream? ########## go/parquet/internal/encoding/byte_stream_split.go: ########## @@ -0,0 +1,297 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package encoding + +import ( + "math" + + "github.com/apache/arrow/go/v17/arrow" + "github.com/apache/arrow/go/v17/internal/bitutils" + "github.com/apache/arrow/go/v17/internal/utils" + "github.com/apache/arrow/go/v17/parquet" + "golang.org/x/xerrors" +) + +type NumericByteStreamSplitType interface { + float32 | float64 | int32 | int64 +} + +type ByteStreamSplitType interface { + NumericByteStreamSplitType | parquet.FixedLenByteArray +} + +// putByteStreamSplitNumeric is a generic implementation of the BYTE_STREAM_SPLIT encoding for fixed-width numeric types. +func putByteStreamSplitNumeric[T NumericByteStreamSplitType](in []T, enc TypedEncoder, sink *PooledBufferWriter) { + numElements := len(in) + typeLen := enc.Type().ByteSize() + bytesNeeded := numElements * typeLen + sink.Reserve(bytesNeeded) + + // Make sure len = cap so we can index into any loc rather than append + data := sink.buf.Bytes() + data = data[:cap(data)] + + inBytes := arrow.GetBytes(in) + for offset := 0; offset < typeLen; offset++ { Review Comment: offset -> stream? ########## go/parquet/internal/encoding/byte_stream_split.go: ########## @@ -0,0 +1,297 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package encoding + +import ( + "math" + + "github.com/apache/arrow/go/v17/arrow" + "github.com/apache/arrow/go/v17/internal/bitutils" + "github.com/apache/arrow/go/v17/internal/utils" + "github.com/apache/arrow/go/v17/parquet" + "golang.org/x/xerrors" +) + +type NumericByteStreamSplitType interface { + float32 | float64 | int32 | int64 +} + +type ByteStreamSplitType interface { + NumericByteStreamSplitType | parquet.FixedLenByteArray +} + +// putByteStreamSplitNumeric is a generic implementation of the BYTE_STREAM_SPLIT encoding for fixed-width numeric types. +func putByteStreamSplitNumeric[T NumericByteStreamSplitType](in []T, enc TypedEncoder, sink *PooledBufferWriter) { + numElements := len(in) + typeLen := enc.Type().ByteSize() + bytesNeeded := numElements * typeLen + sink.Reserve(bytesNeeded) + + // Make sure len = cap so we can index into any loc rather than append + data := sink.buf.Bytes() + data = data[:cap(data)] + + inBytes := arrow.GetBytes(in) + for offset := 0; offset < typeLen; offset++ { + for element := range in { + encLoc := numElements*offset + element + decLoc := typeLen*element + offset + data[encLoc] = inBytes[decLoc] + } + } + + sink.pos += bytesNeeded +} + +// putByteStreamSplitSpaced encodes data that has space for nulls using the BYTE_STREAM_SPLIT encoding, calling to the provided putFn to encode runs of non-null values. +func putByteStreamSplitSpaced[T ByteStreamSplitType](in []T, validBits []byte, validBitsOffset int64, bitSetReader bitutils.SetBitRunReader, putFn func([]T)) { + if validBits == nil { + putFn(in) + return + } + + if bitSetReader == nil { + bitSetReader = bitutils.NewSetBitRunReader(validBits, validBitsOffset, int64(len(in))) + } else { + bitSetReader.Reset(validBits, validBitsOffset, int64(len(in))) + } + + for { + run := bitSetReader.NextRun() + if run.Length == 0 { + break + } + putFn(in[int(run.Pos):int(run.Pos+run.Length)]) + } +} + +// decodeByteStreamSplit is a generic implementation of the BYTE_STREAM_SPLIT decoder for fixed-width numeric types. +func decodeByteStreamSplitNumeric[T NumericByteStreamSplitType](out []T, dec TypedDecoder, data []byte) (int, error) { + max := utils.Min(len(out), dec.ValuesLeft()) + typeLen := dec.Type().ByteSize() + numBytesNeeded := max * typeLen + if numBytesNeeded > len(data) || numBytesNeeded > math.MaxInt32 { + return 0, xerrors.New("parquet: eof exception") + } + + outBytes := arrow.GetBytes(out) + for offset := 0; offset < typeLen; offset++ { + for element := 0; element < max; element++ { + encLoc := max*offset + element + decLoc := typeLen*element + offset + outBytes[decLoc] = data[encLoc] + } + } + + dec.SetData(dec.ValuesLeft()-max, data[max:]) Review Comment: Hmmm so `dec` handles this by `SetData` repeatly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
