mapleFU commented on code in PR #43066:
URL: https://github.com/apache/arrow/pull/43066#discussion_r1661082892
##########
go/parquet/internal/encoding/encoding_test.go:
##########
@@ -406,6 +406,17 @@ func (b *BaseEncodingTestSuite)
TestDeltaByteArrayRoundTrip() {
}
}
+func (b *BaseEncodingTestSuite) TestByteStreamSplitRoundTrip() {
+ b.initData(10000, 1)
+
+ switch b.typ {
+ case reflect.TypeOf(float32(0)), reflect.TypeOf(float64(0)),
reflect.TypeOf(int32(0)), reflect.TypeOf(int64(0)),
reflect.TypeOf(parquet.FixedLenByteArray{}):
Review Comment:
would you mind add a test case for `Put` and read with smaller batch-size?
For example, the data-count is 10000, we can `Put(2500 values)` for 4 times and
flush it. During read, we also read with smaller stride?
##########
go/parquet/internal/encoding/byte_stream_split.go:
##########
@@ -0,0 +1,296 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package encoding
+
+import (
+ "math"
+
+ "github.com/apache/arrow/go/v17/arrow"
+ "github.com/apache/arrow/go/v17/internal/bitutils"
+ "github.com/apache/arrow/go/v17/internal/utils"
+ "github.com/apache/arrow/go/v17/parquet"
+ "golang.org/x/xerrors"
+)
+
+type NumericByteStreamSplitType interface {
+ float32 | float64 | int32 | int64
+}
+
+type ByteStreamSplitType interface {
+ NumericByteStreamSplitType | parquet.FixedLenByteArray
+}
+
+// putByteStreamSplitNumeric is a generic implementation of the
BYTE_STREAM_SPLIT encoding for fixed-width numeric types.
+func putByteStreamSplitNumeric[T NumericByteStreamSplitType](in []T, enc
TypedEncoder, sink *PooledBufferWriter) {
Review Comment:
would this crack the previously put bytes within `sink`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
