laurentgo commented on code in PR #43139:
URL: https://github.com/apache/arrow/pull/43139#discussion_r1664843813
##########
java/flight/flight-core/pom.xml:
##########
@@ -175,6 +177,13 @@ under the License.
<include>com.google.protobuf:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <excludes>
+ <exclude>**/module-info.class</exclude>
Review Comment:
Not sure., maybe we can add [`Automatic-Module-Name`
attribute](https://docs.oracle.com/javase%2F9%2Fdocs%2Fapi%2F%2F/java/lang/module/ModuleFinder.html)
in the shaded jars to make the name not filename dependent.
What it helps with though is having shaded jars which exposes the wrong
module information (like the jackson or gson ones which are copied over under
`META-INF/versions/9/module-info.class`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
