laurentgo commented on code in PR #43139:
URL: https://github.com/apache/arrow/pull/43139#discussion_r1664859566
##########
java/flight/flight-core/pom.xml:
##########
@@ -175,6 +177,13 @@ under the License.
<include>com.google.protobuf:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <excludes>
+ <exclude>**/module-info.class</exclude>
Review Comment:
There's no built-in way to merge all `module-info.class` files into a single
one, one need to analyze what needs to be exported and how to deal also with
relocation.
Specifically for this module, there are 3 different shaded jars with
different set of dependencies included and different set of relocations and I'm
not sure which ones are supposed to be used internally and which ones are to be
used externally. Knowing the intended usage may also guide us in deciding if
those artifacts should be modularized or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
