alamb commented on a change in pull request #9565:
URL: https://github.com/apache/arrow/pull/9565#discussion_r584288331
##########
File path: rust/datafusion/src/physical_plan/type_coercion.rs
##########
@@ -168,20 +168,35 @@ fn maybe_data_types(
pub fn can_coerce_from(type_into: &DataType, type_from: &DataType) -> bool {
use self::DataType::*;
match type_into {
- Int8 => matches!(type_from, Int8),
- Int16 => matches!(type_from, Int8 | Int16 | UInt8),
- Int32 => matches!(type_from, Int8 | Int16 | Int32 | UInt8 | UInt16),
+ Int8 => matches!(type_from, Int8 | Utf8 | LargeUtf8),
Review comment:
I agree that adding an option to the arrow cast kernel to error (rather
than silently return `Null` would be very valuable). I can see usecases for
returning `Null` which is why I don't think we could just change the cast
kernel's behavior. But an option would be lovely ❤️
Sorry for the delay in responding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
