alamb commented on a change in pull request #9565:
URL: https://github.com/apache/arrow/pull/9565#discussion_r586347165
##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -2058,17 +2058,53 @@ async fn test_string_expressions() -> Result<()> {
test_expression!("concat_ws('|','a','b','c')", "a|b|c");
test_expression!("concat_ws('|',NULL)", "");
test_expression!("concat_ws(NULL,'a',NULL,'b','c')", "NULL");
+ test_expression!("left('abcde', -2)", "abc");
+ test_expression!("left('abcde', -200)", "");
+ test_expression!("left('abcde', 0)", "");
+ test_expression!("left('abcde', 2)", "ab");
+ test_expression!("left('abcde', 200)", "abcde");
+ test_expression!("left('abcde', CAST(NULL AS INT))", "NULL");
+ test_expression!("left(NULL, 2)", "NULL");
+ test_expression!("left(NULL, CAST(NULL AS INT))", "NULL");
+ test_expression!("lower('')", "");
+ test_expression!("lower('TOM')", "tom");
+ test_expression!("lower(NULL)", "NULL");
+ test_expression!("lpad('hi', 5, 'xy')", "xyxhi");
+ test_expression!("lpad('hi', 0)", "");
+ test_expression!("lpad('hi', 21, 'abcdef')", "abcdefabcdefabcdefahi");
+ test_expression!("lpad('hi', 5, 'xy')", "xyxhi");
+ test_expression!("lpad('hi', 5, NULL)", "NULL");
+ test_expression!("lpad('hi', 5)", " hi");
+ test_expression!("lpad('hi', CAST(NULL AS INT), 'xy')", "NULL");
+ test_expression!("lpad('hi', CAST(NULL AS INT))", "NULL");
+ test_expression!("lpad('xyxhi', 3)", "xyx");
+ test_expression!("lpad(NULL, 0)", "NULL");
+ test_expression!("lpad(NULL, 5, 'xy')", "NULL");
test_expression!("ltrim(' zzzytest ', NULL)", "NULL");
test_expression!("ltrim(' zzzytest ')", "zzzytest ");
test_expression!("ltrim('zzzytest', 'xyz')", "test");
test_expression!("ltrim(NULL, 'xyz')", "NULL");
- test_expression!("lower('')", "");
- test_expression!("lower('TOM')", "tom");
- test_expression!("lower(NULL)", "NULL");
test_expression!("octet_length('')", "0");
test_expression!("octet_length('chars')", "5");
test_expression!("octet_length('josé')", "5");
test_expression!("octet_length(NULL)", "NULL");
+ test_expression!("right('abcde', -2)", "cde");
+ test_expression!("right('abcde', -200)", "");
+ test_expression!("right('abcde', 0)", "");
+ test_expression!("right('abcde', 2)", "de");
+ test_expression!("right('abcde', 200)", "abcde");
+ test_expression!("right('abcde', CAST(NULL AS INT))", "NULL");
+ test_expression!("right(NULL, 2)", "NULL");
+ test_expression!("right(NULL, CAST(NULL AS INT))", "NULL");
+ test_expression!("rpad('hi', 5, 'xy')", "hixyx");
+ test_expression!("rpad('hi', 0)", "");
+ test_expression!("rpad('hi', 21, 'abcdef')", "hiabcdefabcdefabcdefa");
+ test_expression!("rpad('hi', 5, 'xy')", "hixyx");
+ test_expression!("rpad('hi', 5, NULL)", "NULL");
+ test_expression!("rpad('hi', 5)", "hi ");
+ test_expression!("rpad('hi', CAST(NULL AS INT), 'xy')", "NULL");
Review comment:
it is interesting that the casts that are required are for casting Nulls
`CAST(NULL AS INT)` --- I'll file a ticket to potentially allow that to work (I
think it is fine to coerce a null constant into any type)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
