jorgecarleitao commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r584290973
##########
File path: rust/arrow/src/array/array_string.rs
##########
@@ -205,28 +205,30 @@ where
let (_, data_len) = iter.size_hint();
let data_len = data_len.expect("Iterator must be sized"); // panic if
no upper bound.
Review comment:
shouldn't we just remove this panic here and use the lower bound
instead? Seems feasible after this change (and before?), and IMO is how it
should be (i.e. pre-allocate the lower, not upper, bound).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
