alamb commented on a change in pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#discussion_r587764593



##########
File path: rust/arrow/src/array/array_binary.rs
##########
@@ -258,6 +258,8 @@ where
             }
         }
 
+        // calculate actual data_len, which may be different from the 
iterator's upper bound
+        let data_len = offsets.len() - 1;

Review comment:
       After some more study I agree (that further improvements could be made, 
but this PR makes the situation better so it is good as it is)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to