veluca93 commented on code in PR #6024:
URL: https://github.com/apache/arrow-rs/pull/6024#discussion_r1669980710
##########
parquet/src/util/bit_util.rs:
##########
@@ -435,6 +435,10 @@ impl BitReader {
/// This function panics if
/// - `num_bits` is larger than the bit-capacity of `T`
///
+ // FIXME: soundness issue - this method can be used to write arbitrary
bytes to any
Review Comment:
If FromBytes is crate-private, then it could be made an `unsafe` trait
without any issues, right?
I believe it would be a better choice than relying on implementations to be
correct (in fact, this is pretty much the definition of unsafe traits :-))
I am not sure I understand how this would fix the issue for `bool` though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
