tustvold commented on code in PR #6024:
URL: https://github.com/apache/arrow-rs/pull/6024#discussion_r1670122333
##########
parquet/src/util/bit_util.rs:
##########
@@ -435,6 +435,10 @@ impl BitReader {
/// This function panics if
/// - `num_bits` is larger than the bit-capacity of `T`
///
+ // FIXME: soundness issue - this method can be used to write arbitrary
bytes to any
Review Comment:
You could make it an unsafe trait also.
As for why it fixes the issue for bool, a bit width of 1 means unpack will
not write invalid values (> 1) to the memory locations for bools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
