zeroshade commented on code in PR #43206:
URL: https://github.com/apache/arrow/pull/43206#discussion_r1672419063
##########
.github/workflows/go.yml:
##########
@@ -188,9 +188,13 @@ jobs:
cache: true
cache-dependency-path: go/go.sum
- name: Run build
- run: |
- cd go
- GOARCH=386 go build ./...
+ run: GOARCH=386 go build ./...
+ working-directory: ./go
+ - name: Run test
+ # No asm simd support for 386
+ # WIP refactor, only tests in the specified dirs have been fixed
Review Comment:
does it actually fail without the `noasm` tag? it should be correctly
detecting the architecture and defaulting to the pure go implementations even
without the `noasm` tag. We should fix it otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
