joellubi commented on code in PR #43206:
URL: https://github.com/apache/arrow/pull/43206#discussion_r1672826805
##########
.github/workflows/go.yml:
##########
@@ -188,9 +188,13 @@ jobs:
cache: true
cache-dependency-path: go/go.sum
- name: Run build
- run: |
- cd go
- GOARCH=386 go build ./...
+ run: GOARCH=386 go build ./...
+ working-directory: ./go
+ - name: Run test
+ # No asm simd support for 386
+ # WIP refactor, only tests in the specified dirs have been fixed
Review Comment:
It was failing because we didn't have a `386` variant of the BMI functions.
I just added one and now it works without the build tag. This issue likely
still exists with the other arch-specific function implementations but I think
it's reasonable to go and add those together with the corresponding updates to
`refCount` across other parts of the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
