veluca93 commented on code in PR #6025:
URL: https://github.com/apache/arrow-rs/pull/6025#discussion_r1673751655
##########
parquet/src/arrow/buffer/offset_buffer.rs:
##########
@@ -164,7 +168,8 @@ impl<I: OffsetSizeTrait> OffsetBuffer<I> {
let len = (end - start).to_usize().unwrap();
if len != 0 {
- // Safety: (1) the buffer is valid (2) the offsets are valid
(3) the values in between are of ByteViewType
Review Comment:
Good to know - I rebased and got rid of the code!
##########
parquet/src/arrow/buffer/offset_buffer.rs:
##########
@@ -164,7 +168,8 @@ impl<I: OffsetSizeTrait> OffsetBuffer<I> {
let len = (end - start).to_usize().unwrap();
if len != 0 {
- // Safety: (1) the buffer is valid (2) the offsets are valid
(3) the values in between are of ByteViewType
Review Comment:
Good to know - I rebased and got rid of the comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
