alamb commented on code in PR #6025:
URL: https://github.com/apache/arrow-rs/pull/6025#discussion_r1688632493
##########
parquet/src/arrow/buffer/dictionary_buffer.rs:
##########
@@ -162,6 +162,10 @@ impl<K: ArrowNativeType + Ord, V: OffsetSizeTrait>
DictionaryBuffer<K, V> {
let data = match cfg!(debug_assertions) {
true => builder.build().unwrap(),
+ // SAFETY: FIXME: this is unsound. data_type is passed by
the caller without
Review Comment:
Hi @veluca93 -- I wonder if you have had any more time to do some more code
investigation? If you think this is actually unsound I will try and find more
time to review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
