mapleFU commented on code in PR #6042:
URL: https://github.com/apache/arrow-rs/pull/6042#discussion_r1673837921
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -942,14 +950,19 @@ impl ColumnChunkMetaDataBuilder {
}
}
-/// Builder for column index
+/// Builder for Parquet [`ColumnIndex`], part of the Parquet [PageIndex]
+///
+/// [PageIndex]:
https://github.com/apache/parquet-format/blob/master/PageIndex.md
pub struct ColumnIndexBuilder {
null_pages: Vec<bool>,
min_values: Vec<Vec<u8>>,
max_values: Vec<Vec<u8>>,
null_counts: Vec<i64>,
boundary_order: BoundaryOrder,
- // If one page can't get build index, need to ignore all index in this
column
+ /// Is the information in the builder valid?
+ ///
+ /// Set to `false` if any entry in the page doesn't have statistics for
+ /// some reason
Review Comment:
The reason can be document here, like
https://github.com/apache/parquet-format/pull/196 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
