alamb commented on code in PR #6042:
URL: https://github.com/apache/arrow-rs/pull/6042#discussion_r1678239019
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -988,15 +1008,19 @@ impl ColumnIndexBuilder {
self.boundary_order = boundary_order;
}
+ /// Mark this column index as invalid
pub fn to_invalid(&mut self) {
self.valid = false;
}
+ /// Is the information in the builder valid?
pub fn valid(&self) -> bool {
self.valid
}
/// Build and get the thrift metadata of column index
+ ///
+ /// Note: callers should check [`Self::valid`] before calling this method
Review Comment:
I agree that would be a good improvement -- filed
https://github.com/apache/arrow-rs/issues/6064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
