felipecrv commented on code in PR #43190:
URL: https://github.com/apache/arrow/pull/43190#discussion_r1678025472
##########
cpp/src/arrow/array/concatenate.h:
##########
@@ -24,6 +24,23 @@
#include "arrow/util/visibility.h"
namespace arrow {
+namespace internal {
Review Comment:
The cast suggestion is not stable yet. I think a better cast for strings
would be strings views, but that can only be done when I push a PR that
implements string->string-view casts (I have the code, but it's blocked by some
half-float issues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
