felipecrv commented on code in PR #43190:
URL: https://github.com/apache/arrow/pull/43190#discussion_r1678126142
##########
cpp/src/arrow/array/concatenate.cc:
##########
@@ -818,8 +937,31 @@ Result<std::shared_ptr<Array>> Concatenate(const
ArrayVector& arrays, MemoryPool
}
std::shared_ptr<ArrayData> out_data;
- RETURN_NOT_OK(ConcatenateImpl(data, pool).Concatenate(&out_data));
+ ErrorHints hints;
+ auto status = ConcatenateImpl(data, pool).Concatenate(&out_data, &hints);
+ if (!status.ok()) {
+ if (hints.suggested_cast) {
+ DCHECK(status.IsInvalid());
+ *out_suggested_cast = std::move(hints.suggested_cast);
Review Comment:
I actually should change the comment because this comment was based on a
version of this that used NULL-ness of the output parameter as a factor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
