kangakum36 commented on code in PR #43268:
URL: https://github.com/apache/arrow/pull/43268#discussion_r1679747182
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -382,18 +382,18 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
break;
case ArrowTypeId::TIME32:
type = ParquetType::INT32;
- logical_type =
- LogicalType::Time(/*is_adjusted_to_utc=*/true,
LogicalType::TimeUnit::MILLIS);
+ logical_type =
LogicalType::Time(arrow_properties.time_is_adjusted_to_utc(),
Review Comment:
I see, this makes sense.
Do you think it would make sense to add the `is_adjusted_to_utc` field to
the TIME32/TIME64 data types, instead of having it passed as a writer property?
This would also allow specifying per-column, but I think it would be quite a
large change.
Alternatively, it might be sufficient to log a warning during the schema
conversion on read if a time32/time64 type is not adjusted to UTC? Perhaps in
`NodeToSchemaField` or `GetTypeForNode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
