pitrou commented on code in PR #43268:
URL: https://github.com/apache/arrow/pull/43268#discussion_r1686692052
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -382,18 +382,18 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
break;
case ArrowTypeId::TIME32:
type = ParquetType::INT32;
- logical_type =
- LogicalType::Time(/*is_adjusted_to_utc=*/true,
LogicalType::TimeUnit::MILLIS);
+ logical_type =
LogicalType::Time(arrow_properties.time_is_adjusted_to_utc(),
Review Comment:
As I said below, I think this flag makes no sense for times. It's ok to
write it to Parquet for compatibility, but all times are conceptually local to
an unspecified timezone, with no possibility to compute an equivalent "UTC
time" since you don't know on which day is was measured.
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -382,18 +382,18 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
break;
case ArrowTypeId::TIME32:
type = ParquetType::INT32;
- logical_type =
- LogicalType::Time(/*is_adjusted_to_utc=*/true,
LogicalType::TimeUnit::MILLIS);
+ logical_type =
LogicalType::Time(arrow_properties.time_is_adjusted_to_utc(),
Review Comment:
As I said below, I think this flag makes no sense for times. It's ok to
write it to Parquet for compatibility, but all times are conceptually local to
an unspecified timezone, with no possibility to compute an equivalent "UTC
time" since you don't know on which day it was measured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
