alamb commented on code in PR #6025:
URL: https://github.com/apache/arrow-rs/pull/6025#discussion_r1700896255
##########
parquet/src/arrow/buffer/dictionary_buffer.rs:
##########
@@ -162,6 +162,10 @@ impl<K: ArrowNativeType + Ord, V: OffsetSizeTrait>
DictionaryBuffer<K, V> {
let data = match cfg!(debug_assertions) {
true => builder.build().unwrap(),
+ // SAFETY: FIXME: this is unsound. data_type is passed by
the caller without
Review Comment:
I am likewise not familar with this part of the code -- and I haven't been
able to find time to spend studying it in detail.
One of the nice things about open source code is that it is all available
for everyone to look -- I welcome additional thoughts / reviews / assistance on
this item
FRom my perspective, this ticket is current a reasearch item as it is a
seemingly theoretical problem. Thus it will likely will remain a relatively
low priority for me personally unless someone can cook up a rust example
showing actual unsafe/unsound behavior resulting
thank you again for the help. It would be great if you could find time to
analyze the code or make an example showing a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
