lidavidm commented on code in PR #43053:
URL: https://github.com/apache/arrow/pull/43053#discussion_r1690621779
##########
java/c/src/test/python/integration_tests.py:
##########
Review Comment:
Can we test all types?
##########
java/c/src/main/java/org/apache/arrow/c/BufferImportTypeVisitor.java:
##########
@@ -116,7 +119,7 @@ private ArrowBuf importFixedBytes(ArrowType type, int
index, long bytesPerSlot)
}
private ArrowBuf importOffsets(ArrowType type, long bytesPerSlot) {
- final long capacity = bytesPerSlot * (fieldNode.getLength() + 1);
+ final long capacity = bytesPerSlot * (fieldNode.getLength() +
arrowArrayOffset + 1);
Review Comment:
Why are we adjusting capacity here?
##########
java/c/src/test/python/integration_tests.py:
##########
@@ -54,11 +54,11 @@ def setup_jvm():
# For debugging purpose please uncomment the following, and include
*jvm_args, before **kwargs
# in startJVM function call
- # jvm_args = [
- #
"-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"
- # ]
+ jvm_args = [
+ "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005"
+ ]
- jpype.startJVM(jpype.getDefaultJVMPath(), "-Djava.class.path=" + jar_path,
**kwargs)
+ jpype.startJVM(jpype.getDefaultJVMPath(), "-Djava.class.path=" + jar_path,
*jvm_args, **kwargs)
Review Comment:
I don't think you meant to leave this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
