vibhatha commented on code in PR #43053:
URL: https://github.com/apache/arrow/pull/43053#discussion_r1690688222
##########
java/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:
##########
@@ -951,6 +952,86 @@ public void testImportReleasedArray() {
}
}
+ @Test
Review Comment:
Right, one question related to that. From C++ we could get the full offset,
validity and data buffers, that's right. In Java, we would use the
`arrowArrayOffset` to determine the first offset, and take dataLength + 1 from
the first offset. This is a must right?
And for validity buffer we can just import what is sent, and for data
buffer, we need to determine the capacity, because the known information are
via the adjustedOffset buffer. So that last value would have the length of the
buffer we need to read. Though this will contain unnecessary values at the
beginning of the buffer, but since we have correct offsets, the vector can
interpret the data accurately.
Is this understanding correct? Or does it have issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
