XiangpengHao opened a new pull request, #6136:
URL: https://github.com/apache/arrow-rs/pull/6136

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #6094.
   
   # Rationale for this change
   StringView users will by default benefit from exponential block size growth 
to keep the buffer count low.
   
   <!--
   Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   I try to make the change simple unless we have a reason for more complexed 
implementation.
   
   My justification:
   - I would like to keep the size of builder small, previously 212 bytes, now 
it is 216 bytes (+4). Large builder is less memory efficient and make me 
hesitate to use builder on performance critical code.
   - Currently the largest size is 2MB, starting size is 8KB. Although those 
are fixed values, I think they should cover most of the use cases. If users 
want larger size, they would go with the Fixed strategy.
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to