ariesdevil commented on code in PR #6136: URL: https://github.com/apache/arrow-rs/pull/6136#discussion_r1693971485
########## arrow-array/src/builder/generic_bytes_view_builder.rs: ########## @@ -30,7 +30,29 @@ use crate::types::bytes::ByteArrayNativeType; use crate::types::{BinaryViewType, ByteViewType, StringViewType}; use crate::{ArrayRef, GenericByteViewArray}; -const DEFAULT_BLOCK_SIZE: u32 = 8 * 1024; +const STARTING_BLOCK_SIZE: u32 = 8 * 1024; // 8KB +const MAX_BLOCK_SIZE: u32 = 2 * 1024 * 1024; // 2MB Review Comment: 8KiB, 2MiB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org