amol- commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1695604102
##########
python/pyarrow/pandas_compat.py:
##########
@@ -85,27 +89,32 @@ def get_logical_type(arrow_type):
return 'object'
-_numpy_logical_type_map = {
- np.bool_: 'bool',
- np.int8: 'int8',
- np.int16: 'int16',
- np.int32: 'int32',
- np.int64: 'int64',
- np.uint8: 'uint8',
- np.uint16: 'uint16',
- np.uint32: 'uint32',
- np.uint64: 'uint64',
- np.float32: 'float32',
- np.float64: 'float64',
- 'datetime64[D]': 'date',
- np.str_: 'string',
- np.bytes_: 'bytes',
-}
+def get_numpy_logical_type_map():
+ global _numpy_logical_type_map
+ if not _numpy_logical_type_map:
+ _numpy_logical_type_map.update({
+ np.bool_: 'bool',
+ np.int8: 'int8',
+ np.int16: 'int16',
+ np.int32: 'int32',
+ np.int64: 'int64',
+ np.uint8: 'uint8',
+ np.uint16: 'uint16',
+ np.uint32: 'uint32',
+ np.uint64: 'uint64',
+ np.float32: 'float32',
+ np.float64: 'float64',
+ 'datetime64[D]': 'date',
+ np.str_: 'string',
+ np.bytes_: 'bytes',
+ })
+ return _numpy_logical_type_map
def get_logical_type_from_numpy(pandas_collection):
+ numpy_logical_type_map = get_numpy_logical_type_map()
try:
- return _numpy_logical_type_map[pandas_collection.dtype.type]
+ return numpy_logical_type_map[pandas_collection.dtype.type]
Review Comment:
I suggest we make the `get_numpy_logical_type_map` throw a proper error when
`numpy` is not available. Currently this check would throw a `KeyError` and
would do pretty random things with anything that has a `dtype` attribute.
Same for `get_pandas_logical_type_map`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
